archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen: remove redundant initialization of variable irq
@ 2020-06-11 12:31 Colin King
  0 siblings, 0 replies; only message in thread
From: Colin King @ 2020-06-11 12:31 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Bjorn Helgaas, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, x86, H . Peter Anvin, xen-devel,
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <>

The variable irq is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <>
 arch/x86/pci/xen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index e3f1ca316068..9f9aad42ccff 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -62,7 +62,7 @@ static int xen_pcifront_enable_irq(struct pci_dev *dev)
 static int xen_register_pirq(u32 gsi, int triggering, bool set_pirq)
-	int rc, pirq = -1, irq = -1;
+	int rc, pirq = -1, irq;
 	struct physdev_map_pirq map_irq;
 	int shareable = 0;
 	char *name;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-11 12:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 12:31 [PATCH] xen: remove redundant initialization of variable irq Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).