From: Sam Ravnborg <sam@ravnborg.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
Philippe CORNU <philippe.cornu@st.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister()
Date: Sat, 20 Jun 2020 11:20:05 +0000 [thread overview]
Message-ID: <20200620112005.GA16901@ravnborg.org> (raw)
In-Reply-To: <20200618134650.44311-1-weiyongjun1@huawei.com>
Hi Wei.
On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote:
> It's not necessary to unregister backlight device which
> registered with devm_backlight_device_register().
>
> Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks, pushed to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index 895ee3d1371e..d956522f32ee 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> if (ret < 0) {
> dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n");
> drm_panel_remove(&ctx->panel);
> - backlight_device_unregister(ctx->bl_dev);
> return ret;
> }
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-20 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 13:46 [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Wei Yongjun
2020-06-20 11:20 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200620112005.GA16901@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.cornu@st.com \
--cc=thierry.reding@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).