From: Colin King <colin.king@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Barry Song <song.bao.hua@hisilicon.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Mike Kravetz <mike.kravetz@oracle.com>,
Roman Gushchin <guro@fb.com>,
linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] mm: cma: remove redundant null check of the array cma->name
Date: Mon, 22 Jun 2020 14:48:50 +0000 [thread overview]
Message-ID: <20200622144850.45952-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
An earlier commit changed name from a pointer to an array so the
cma->name null check is now redundant and can be removed.
Addresses-Coverity: ("Array compared against 0")
Fixes: e7f0557d7de9 ("mm: cma: fix the name of CMA areas")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
mm/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/cma.c b/mm/cma.c
index 31a61d410c59..6cf08817bac6 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -52,7 +52,7 @@ unsigned long cma_get_size(const struct cma *cma)
const char *cma_get_name(const struct cma *cma)
{
- return cma->name ? cma->name : "(undefined)";
+ return cma->name;
}
static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
--
2.27.0
reply other threads:[~2020-06-22 14:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622144850.45952-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).