archive mirror
 help / color / mirror / Atom feed
* [PATCH] input: i8042: remove redundant assignment to variable retval
@ 2020-06-22 16:31 Colin King
  0 siblings, 0 replies; only message in thread
From: Colin King @ 2020-06-22 16:31 UTC (permalink / raw)
  To: Dmitry Torokhov, Rajat Jain, Stephen Boyd, linux-input
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <>

The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <>
 drivers/input/serio/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 0dddf273afd9..cbaae80065e1 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -796,7 +796,7 @@ static int __init i8042_toggle_aux(bool on)
 static int __init i8042_check_aux(void)
-	int retval = -1;
+	int retval;
 	bool irq_registered = false;
 	bool aux_loop_broken = false;
 	unsigned long flags;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-22 16:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 16:31 [PATCH] input: i8042: remove redundant assignment to variable retval Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).