From: Shawn Guo <shawnguo@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Yu Kuai <yukuai3@huawei.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, Anson Huang <Anson.Huang@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Yi Zhang <yi.zhang@huawei.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: ARM: imx6: add missing put_device() call in imx6q_suspend_init()
Date: Tue, 23 Jun 2020 07:32:21 +0000 [thread overview]
Message-ID: <20200623073220.GV30139@dragon> (raw)
In-Reply-To: <1542979d-f7f6-bcf1-53c3-22b7c076ddc7@web.de>
On Fri, Jun 05, 2020 at 12:15:32PM +0200, Markus Elfring wrote:
> >> Do you find a previous update suggestion useful?
> >>
> >> ARM: imx6: Add missing put_device() call in imx6q_suspend_init()
> >> https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/
> >> https://lore.kernel.org/patchwork/patch/1151158/
> >> https://lkml.org/lkml/2019/11/9/125
> …
> > It is useful indeed.
>
> Thanks for your positive feedback.
>
>
> > Although I didn't run cocci script, since it can produce too many false result
> > which is hard to filter out.
>
> Would you like to clarify any corresponding software analysis options?
>
>
> > BTW, I see you haver done the work already, I guess I won't send any patches
> > related to 'missing put_device after of_find_device_by_node()'.
>
> You may continue also with contributions in such a direction.
> I would like to point out that other developers occasionally got into the mood
> to improve implementation details in similar ways already.
>
>
> > Any idea why these pathes didn't get applied ?
>
> I can make assumptions about the reasons for the possibly questionable handling
> of such patches.
Markus,
Could you resend it to my kernel.org address?
Shawn
next prev parent reply other threads:[~2020-06-23 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 15:30 [PATCH] ARM: imx6: Add missing put_device() call in imx6q_suspend_init() Markus Elfring
2020-06-04 19:07 ` [PATCH] ARM: imx6: add " Markus Elfring
2020-06-05 9:08 ` yukuai (C)
2020-06-05 10:15 ` Markus Elfring
2020-06-23 7:32 ` Shawn Guo [this message]
2020-06-23 7:48 ` Markus Elfring
2020-06-23 11:02 ` Shawn Guo
2020-06-23 12:00 ` Markus Elfring
2020-06-23 12:09 ` Shawn Guo
2020-06-23 12:28 ` Markus Elfring
2020-06-23 12:36 ` Shawn Guo
2020-06-23 14:33 ` Markus Elfring
2020-06-24 14:26 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623073220.GV30139@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Markus.Elfring@web.de \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).