From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] intel_idle: Fix uninitialized variable bug
Date: Thu, 25 Jun 2020 09:04:49 +0000 [thread overview]
Message-ID: <20200625090449.GA2549@kadam> (raw)
In-Reply-To: <CAJZ5v0hG2FL0VSeE+ind9MSMc_c7nA4KjKxFPdMhVOPrMdYJKQ@mail.gmail.com>
On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote:
> On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "tick" variable isn't initialized if "lapic_timer_always_reliable"
> > is true.
>
> If lapic_timer_always_reliable is true, then
> static_cpu_has(X86_FEATURE_ARAT) must also be true AFAICS.
>
> So the lapic_timer_always_reliable check in there looks redundant.
Can the lapic_timer_always_reliable variable just be removed entirely
and replaced with an static_cpu_has(X86_FEATURE_ARAT) check?
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-25 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 13:19 [PATCH] intel_idle: Fix uninitialized variable bug Dan Carpenter
2020-06-24 13:41 ` Rafael J. Wysocki
2020-06-25 9:04 ` Dan Carpenter [this message]
2020-06-25 10:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625090449.GA2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).