From: Michael Tretter <m.tretter@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: allegro: Fix some NULL vs IS_ERR() checks in probe
Date: Wed, 01 Jul 2020 07:06:29 +0000 [thread overview]
Message-ID: <20200701070629.GA16164@pengutronix.de> (raw)
In-Reply-To: <20200619143007.GC267142@mwanda>
On Fri, 19 Jun 2020 17:30:07 +0300, Dan Carpenter wrote:
> The devm_ioremap() function doesn't return error pointers, it returns
> NULL on error.
>
> Fixes: f20387dfd065 ("media: allegro: add Allegro DVT video IP core driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> drivers/staging/media/allegro-dvt/allegro-core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c
> index 70f133a842dd..3ed66aae741d 100644
> --- a/drivers/staging/media/allegro-dvt/allegro-core.c
> +++ b/drivers/staging/media/allegro-dvt/allegro-core.c
> @@ -3065,9 +3065,9 @@ static int allegro_probe(struct platform_device *pdev)
> return -EINVAL;
> }
> regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> - if (IS_ERR(regs)) {
> + if (!regs) {
> dev_err(&pdev->dev, "failed to map registers\n");
> - return PTR_ERR(regs);
> + return -ENOMEM;
> }
> dev->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
> &allegro_regmap_config);
> @@ -3085,9 +3085,9 @@ static int allegro_probe(struct platform_device *pdev)
> sram_regs = devm_ioremap(&pdev->dev,
> sram_res->start,
> resource_size(sram_res));
> - if (IS_ERR(sram_regs)) {
> + if (!sram_regs) {
> dev_err(&pdev->dev, "failed to map sram\n");
> - return PTR_ERR(sram_regs);
> + return -ENOMEM;
> }
> dev->sram = devm_regmap_init_mmio(&pdev->dev, sram_regs,
> &allegro_sram_config);
> --
> 2.27.0
>
>
prev parent reply other threads:[~2020-07-01 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:30 [PATCH] media: allegro: Fix some NULL vs IS_ERR() checks in probe Dan Carpenter
2020-07-01 7:06 ` Michael Tretter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701070629.GA16164@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).