* [PATCH][next] staging: wfx: fix uninitialized variable bytes_done
@ 2020-07-06 13:20 Colin King
2020-07-06 13:29 ` Jérôme Pouiller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-07-06 13:20 UTC (permalink / raw)
To: Jérôme Pouiller, Greg Kroah-Hartman, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable bytes_done is not initialized and hence the first
FIFO size check on bytes_done may be breaking prematurely from
the loop if bytes_done contains a large bogus uninitialized value.
Fix this by initializing bytes_done to zero.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: a9408ad79ff3 ("staging: wfx: load the firmware faster")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/wfx/fwio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c
index d9a886f3e64b..206c6cf6511c 100644
--- a/drivers/staging/wfx/fwio.c
+++ b/drivers/staging/wfx/fwio.c
@@ -177,7 +177,7 @@ static int wait_ncp_status(struct wfx_dev *wdev, u32 status)
static int upload_firmware(struct wfx_dev *wdev, const u8 *data, size_t len)
{
int ret;
- u32 offs, bytes_done;
+ u32 offs, bytes_done = 0;
ktime_t now, start;
if (len % DNLD_BLOCK_SIZE) {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] staging: wfx: fix uninitialized variable bytes_done
2020-07-06 13:20 [PATCH][next] staging: wfx: fix uninitialized variable bytes_done Colin King
@ 2020-07-06 13:29 ` Jérôme Pouiller
0 siblings, 0 replies; 2+ messages in thread
From: Jérôme Pouiller @ 2020-07-06 13:29 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, Colin King; +Cc: kernel-janitors, linux-kernel
On Monday 6 July 2020 15:20:17 CEST Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable bytes_done is not initialized and hence the first
> FIFO size check on bytes_done may be breaking prematurely from
> the loop if bytes_done contains a large bogus uninitialized value.
> Fix this by initializing bytes_done to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: a9408ad79ff3 ("staging: wfx: load the firmware faster")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Good catch!
I am surprised that my gcc hasn't caught that.
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
> drivers/staging/wfx/fwio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c
> index d9a886f3e64b..206c6cf6511c 100644
> --- a/drivers/staging/wfx/fwio.c
> +++ b/drivers/staging/wfx/fwio.c
> @@ -177,7 +177,7 @@ static int wait_ncp_status(struct wfx_dev *wdev, u32 status)
> static int upload_firmware(struct wfx_dev *wdev, const u8 *data, size_t len)
> {
> int ret;
> - u32 offs, bytes_done;
> + u32 offs, bytes_done = 0;
> ktime_t now, start;
>
> if (len % DNLD_BLOCK_SIZE) {
> --
> 2.27.0
>
>
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-06 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 13:20 [PATCH][next] staging: wfx: fix uninitialized variable bytes_done Colin King
2020-07-06 13:29 ` Jérôme Pouiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).