* [PATCH] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
@ 2020-07-09 10:49 Dan Carpenter
2020-07-09 10:56 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2020-07-09 10:49 UTC (permalink / raw)
To: James Smart, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, kernel-janitors
These variables are unsigned so the result of the subtraction is also
unsigned and thus can't be negative. Change it to a comparison and
remove the subtraction.
Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 7285b0114837..2bb2c96e7784 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
} else {
- if ((start_idx - dbg_cnt) < 0) {
+ if (start_idx > dbg_cnt) {
start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
temp_idx = 0;
} else {
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
2020-07-09 10:49 [PATCH] scsi: lpfc: Fix a condition in lpfc_dmp_dbg() Dan Carpenter
@ 2020-07-09 10:56 ` Dan Carpenter
2020-07-09 10:58 ` [PATCH v2] " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2020-07-09 10:56 UTC (permalink / raw)
To: James Smart, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, kernel-janitors
On Thu, Jul 09, 2020 at 01:49:19PM +0300, Dan Carpenter wrote:
> These variables are unsigned so the result of the subtraction is also
> unsigned and thus can't be negative. Change it to a comparison and
> remove the subtraction.
>
> Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 7285b0114837..2bb2c96e7784 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
> if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
> temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
> } else {
> - if ((start_idx - dbg_cnt) < 0) {
> + if (start_idx > dbg_cnt) {
Nope. That's reversed. I'm dumb. Let me resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
2020-07-09 10:56 ` Dan Carpenter
@ 2020-07-09 10:58 ` Dan Carpenter
2020-07-09 14:43 ` James Smart
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2020-07-09 10:58 UTC (permalink / raw)
To: James Smart, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, kernel-janitors
These variables are unsigned so the result of the subtraction is also
unsigned and thus can't be negative. Change it to a comparison and
remove the subtraction.
Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: I reverse the if statement in v1
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 7285b0114837..2bb2c96e7784 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
} else {
- if ((start_idx - dbg_cnt) < 0) {
+ if (start_idx < dbg_cnt) {
start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
temp_idx = 0;
} else {
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
2020-07-09 10:58 ` [PATCH v2] " Dan Carpenter
@ 2020-07-09 14:43 ` James Smart
0 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2020-07-09 14:43 UTC (permalink / raw)
To: Dan Carpenter, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, kernel-janitors
On 7/9/2020 3:58 AM, Dan Carpenter wrote:
> These variables are unsigned so the result of the subtraction is also
> unsigned and thus can't be negative. Change it to a comparison and
> remove the subtraction.
>
> Fixes: 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: I reverse the if statement in v1
>
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 7285b0114837..2bb2c96e7784 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)
> if ((start_idx + dbg_cnt) > (DBG_LOG_SZ - 1)) {
> temp_idx = (start_idx + dbg_cnt) % DBG_LOG_SZ;
> } else {
> - if ((start_idx - dbg_cnt) < 0) {
> + if (start_idx < dbg_cnt) {
> start_idx = DBG_LOG_SZ - (dbg_cnt - start_idx);
> temp_idx = 0;
> } else {
Already resolved/accepted.
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?idwdd7d7b3442
Thank you though.
-- james
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-09 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 10:49 [PATCH] scsi: lpfc: Fix a condition in lpfc_dmp_dbg() Dan Carpenter
2020-07-09 10:56 ` Dan Carpenter
2020-07-09 10:58 ` [PATCH v2] " Dan Carpenter
2020-07-09 14:43 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).