From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suraj Upadhyay Date: Mon, 13 Jul 2020 05:56:24 +0000 Subject: Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs. Message-Id: <20200713054424.GD12262@blackclown> MIME-Version: 1 Content-Type: multipart/mixed; boundary="7DO5AaGCk89r4vaK" List-Id: References: <20200711124633.GA16459@blackclown> <20200713045959.GA7563@f3> In-Reply-To: <20200713045959.GA7563@f3> To: Benjamin Poirier Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org --7DO5AaGCk89r4vaK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h APIs, instead use dma-mapping.h > > APIs directly. > >=20 > > The patch has been generated with the coccinelle script below > > and compile-tested. > >=20 > [...] > >=20 > > @@ expression E1, E2, E3, E4; @@ > > - pci_dma_sync_single_for_device(E1, E2, E3, E4) > > + dma_sync_single_for_device(&E1->dev, E2, E3, (enum dma_data_direction= )E4) >=20 > The qlge driver contains more usages of the deprecated pci_dma_* api > than what this diff addresses. In particular, there are some calls to > pci_dma_sync_single_for_cpu() which were not changed despite this > expression being in the semantic patch. Hii Ben, I couldn't find any instances of pci_dma_sync_single_for_cpu in the drivers/staging/qlge/ driver, I ran a simple `git grep pci_dma_sync_sin= gle_for_cpu/device` and got nothing. If I am wrong, please send the line number of the usages. > Dunno what happened but it should be reviewed. After converting away > from all of the old api, the TODO file should also be updated. Thanks for reminding me this, I would send a follow up patch to remove "pci_dma_*" from "avoid legacy/deprecated apis (ex. replace pci_dma_*, repl= ace pci_enable_msi, use pci_iomap)". Thanks and Cheers, Suraj Upadhyay. > [...] >=20 > >=20 > > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlg= e_mpi.c > > index fa178fc642a6..16a9bf818346 100644 > > --- a/drivers/staging/qlge/qlge_mpi.c > > +++ b/drivers/staging/qlge/qlge_mpi.c > > @@ -788,8 +788,9 @@ int ql_dump_risc_ram_area(struct ql_adapter *qdev, = void *buf, > > char *my_buf; > > dma_addr_t buf_dma; > > =20 > > - my_buf =3D pci_alloc_consistent(qdev->pdev, word_count * sizeof(u32), > > - &buf_dma); > > + my_buf =3D dma_alloc_coherent(&qdev->pdev->dev, > > + word_count * sizeof(u32), &buf_dma, > > + GFP_ATOMIC); > > if (!my_buf) > > return -EIO; > > =20 > > @@ -797,8 +798,8 @@ int ql_dump_risc_ram_area(struct ql_adapter *qdev, = void *buf, > > if (!status) > > memcpy(buf, my_buf, word_count * sizeof(u32)); > > =20 > > - pci_free_consistent(qdev->pdev, word_count * sizeof(u32), my_buf, > > - buf_dma); > > + dma_free_coherent(&qdev->pdev->dev, word_count * sizeof(u32), my_buf, > > + buf_dma); > > return status; > > } > > =20 > > --=20 > > 2.17.1 > >=20 >=20 >=20 --7DO5AaGCk89r4vaK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE7AbCa0kOsMJ4cx0j+gRsbIfe744FAl8L9K8ACgkQ+gRsbIfe 747xhxAApBto7Dbd7UotsciB3ZqhS3Rg74Hrfr/+WoBAk94f18vyobZG69zfN1uO i8xzQr4C5LnN2gVr9R2EoOSYxaddNvXmog5evd6nsgW1SboyUUZBBZ9P/OXqrzXr GUpbP/aYt0ITuUCoa7zyvnGDom4S+u+/RV4++0fnKU+9iv6KxHUHxO/jQ6uz0eBN JlhHTN2i/4ML6j6w97vx4ALqfTxkxAmZMlvvMGboqHbMeQybiPwQ/4qiEBQPexdK 1YFrORjBseJF9VPK8vbVBB9qBe7bAKvlaETlWHCqsUmjLbf7rwBUu9VeO9AMydZ2 XwD7OzOv8JLZO/rpAvn1wPWaFUfInUwObgHXTXEYtvs02VrMoODYVJWxCtVK6Ldj ESB812VmuqD+ukBzQim1tfzovuFB2tvJH0DwnzZc5e47trUP0Im5E8+nUW9erkrP nlpXrH522wnLTMONaKvFIGaa1gzI1056f51OmnSY+iFrQMSnT8LRFPGXB7WrnGqz wBz+K7C0+qkuyoIw+D4MfS6X1etpszwkCFFpbQHT5uSM3ce0m8LMUYwIBESWn/Vr xn0KQJQc5P8m4v8DRYX0+uIWjsuo2Pev3WciLA6dvrREz6g+gnJE/dZq3W63rLsi oLy5hJTjwGfmn9pc7gLC2Ma+8BN7MaRLZvbxT+6IvJUcHhsMF+o= =u72M -----END PGP SIGNATURE----- --7DO5AaGCk89r4vaK--