* [PATCH] staging: media: atomisp: Replace depracated MSI API.
@ 2020-07-18 13:38 Suraj Upadhyay
2020-07-19 4:48 ` Suraj Upadhyay
0 siblings, 1 reply; 2+ messages in thread
From: Suraj Upadhyay @ 2020-07-18 13:38 UTC (permalink / raw)
To: mchehab, sakari.ailus, gregkh
Cc: devel, kernel-janitors, linux-kernel, linux-media
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
And as a result modify how the returned value is handled.
Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index d36809a0182c..b824c6f78a9c 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1735,8 +1735,8 @@ static int atomisp_pci_probe(struct pci_dev *dev,
pci_set_master(dev);
pci_set_drvdata(dev, isp);
- err = pci_enable_msi(dev);
- if (err) {
+ err = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI);
+ if (err < 0) {
dev_err(&dev->dev, "Failed to enable msi (%d)\n", err);
goto enable_msi_fail;
}
--
2.17.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: atomisp: Replace depracated MSI API.
2020-07-18 13:38 [PATCH] staging: media: atomisp: Replace depracated MSI API Suraj Upadhyay
@ 2020-07-19 4:48 ` Suraj Upadhyay
0 siblings, 0 replies; 2+ messages in thread
From: Suraj Upadhyay @ 2020-07-19 4:48 UTC (permalink / raw)
To: mchehab, sakari.ailus, gregkh
Cc: devel, kernel-janitors, linux-kernel, linux-media
On Sat, Jul 18, 2020 at 06:56:32PM +0530, Suraj Upadhyay wrote:
> Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
> And as a result modify how the returned value is handled.
>
> Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Hii,
Please don't merge this patch.
It is still incomplete.
It doesn't replace pci_disable_msi.
I hope this wasn't an annoyance.
Thanks,
Suraj Upadhyay.
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index d36809a0182c..b824c6f78a9c 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -1735,8 +1735,8 @@ static int atomisp_pci_probe(struct pci_dev *dev,
> pci_set_master(dev);
> pci_set_drvdata(dev, isp);
>
> - err = pci_enable_msi(dev);
> - if (err) {
> + err = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_MSI);
> + if (err < 0) {
> dev_err(&dev->dev, "Failed to enable msi (%d)\n", err);
> goto enable_msi_fail;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-19 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 13:38 [PATCH] staging: media: atomisp: Replace depracated MSI API Suraj Upadhyay
2020-07-19 4:48 ` Suraj Upadhyay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).