From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Tai-hwa Liang <avatar@sentelic.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] input: sentelic: fix error return when fsp_reg_write fails
Date: Thu, 06 Aug 2020 22:36:21 +0000 [thread overview]
Message-ID: <20200806223621.GM1665100@dtor-ws> (raw)
In-Reply-To: <20200603141218.131663-1-colin.king@canonical.com>
On Wed, Jun 03, 2020 at 03:12:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when the call to fsp_reg_write fails -EIO is not being returned
> because the count is being returned instead of the return value in retval.
> Fix this by returning the value in retval instead of count.
>
> Addresses-Coverity: ("Unused value")
> Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2020-08-06 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 14:12 [PATCH] input: sentelic: fix error return when fsp_reg_write fails Colin King
2020-08-06 22:36 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806223621.GM1665100@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=avatar@sentelic.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).