From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 14 Sep 2020 13:57:57 +0000 Subject: Re: [PATCH] PM / devfreq: tegra30: disable clock on error in probe Message-Id: <20200914135757.GA18329@kadam> List-Id: References: <20200908072557.GC294938@mwanda> <2ceb045a-ebac-58d7-0250-4ea39d711ce8@samsung.com> In-Reply-To: <2ceb045a-ebac-58d7-0250-4ea39d711ce8@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chanwoo Choi Cc: Dmitry Osipenko , MyungJoo Ham , Kyungmin Park , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Sep 14, 2020 at 04:09:02PM +0900, Chanwoo Choi wrote: > Hi, > > On 9/8/20 4:25 PM, Dan Carpenter wrote: > > This error path needs to call clk_disable_unprepare(). > > > > Fixes: 7296443b900e ("PM / devfreq: tegra30: Handle possible round-rate error") > > Signed-off-by: Dan Carpenter > > --- > > --- > > drivers/devfreq/tegra30-devfreq.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > > index e94a27804c20..dedd39de7367 100644 > > --- a/drivers/devfreq/tegra30-devfreq.c > > +++ b/drivers/devfreq/tegra30-devfreq.c > > @@ -836,7 +836,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > > rate = clk_round_rate(tegra->emc_clock, ULONG_MAX); > > if (rate < 0) { > > dev_err(&pdev->dev, "Failed to round clock rate: %ld\n", rate); > > - return rate; > > + err = rate; > > + goto disable_clk; > > } > > > > tegra->max_freq = rate / KHZ; > > @@ -897,6 +898,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > > dev_pm_opp_remove_all_dynamic(&pdev->dev); > > > > reset_control_reset(tegra->reset); > > +disable_clk: > > clk_disable_unprepare(tegra->clock); > > Is it doesn't need to reset with reset_contrl_reset()? Is that a rhetorical question? I don't know this code very well but it looks like you are right. I'll send a v2. regards, dan carpenter