From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Mon, 14 Sep 2020 14:13:32 +0000 Subject: Re: [PATCH][next] misc: hisi_hikey_usb: fix return of uninitialized ret status variable Message-Id: <20200914161332.2796e7b1@coco.lan> List-Id: References: <20200914135646.99334-1-colin.king@canonical.com> In-Reply-To: <20200914135646.99334-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: John Stultz , Arnd Bergmann , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Em Mon, 14 Sep 2020 14:56:46 +0100 Colin King escreveu: > From: Colin Ian King > > Currently the return value from ret is uninitialized so the function > hisi_hikey_usb_parse_kirin970 is returning a garbage value when > succeeding. Since ret is not used anywhere else in the function, remove > it and just return 0 success at the end of the function. > > Addresses-Coverity: ("Uninitialixed scalar variable") > Fixes: d210a0023590 ("misc: hisi_hikey_usb: add support for Hikey 970") > Signed-off-by: Colin Ian King Reviewed-by: Mauro Carvalho Chehab > --- > drivers/misc/hisi_hikey_usb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/hisi_hikey_usb.c b/drivers/misc/hisi_hikey_usb.c > index 2ddd4072788d..5759e7209023 100644 > --- a/drivers/misc/hisi_hikey_usb.c > +++ b/drivers/misc/hisi_hikey_usb.c > @@ -151,7 +151,6 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev, > struct hisi_hikey_usb *hisi_hikey_usb) > { > struct regulator *regulator; > - int ret; > > regulator = devm_regulator_get(&pdev->dev, "hub-vdd"); > if (IS_ERR(regulator)) { > @@ -172,7 +171,7 @@ static int hisi_hikey_usb_parse_kirin970(struct platform_device *pdev, > if (IS_ERR(hisi_hikey_usb->reset)) > return PTR_ERR(hisi_hikey_usb->reset); > > - return ret; > + return 0; > } > > static int hisi_hikey_usb_probe(struct platform_device *pdev) Thanks, Mauro