From: Pavel Machek <pavel@denx.de>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Pavel Machek <pavel@denx.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
syzbot+96414aa0033c363d8458@syzkaller.appspotmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lihong Kou <koulihong@huawei.com>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH] 6lowpan: Add missing locking
Date: Sun, 20 Sep 2020 20:51:11 +0000 [thread overview]
Message-ID: <20200920205111.GA31185@duo.ucw.cz> (raw)
In-Reply-To: <2325b986-a4ea-9aa3-40ba-702ebe9b519c@web.de>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Sun 2020-09-20 16:14:22, Markus Elfring wrote:
> > I believe set_lock should be taken in exit function, too.
>
> * Would an imperative wording become helpful for the change description?
>
> * How do you think about to add the tag “Fixes” to the commit message?
Hi,
This is the semi-friendly notice stolen from Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
parent reply other threads:[~2020-09-20 20:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2325b986-a4ea-9aa3-40ba-702ebe9b519c@web.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200920205111.GA31185@duo.ucw.cz \
--to=pavel@denx.de \
--cc=Markus.Elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=koulihong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=syzbot+96414aa0033c363d8458@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).