From: Steven Rostedt <rostedt@goodmis.org>
To: Walter Harms <wharms@bfs.de>
Cc: Fedor Tokarev <ftokarev@gmail.com>,
"acme@redhat.com" <acme@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] tools: net: traceevent: Fix 'snprintf' return value check in 'tep_filter_strerror'
Date: Thu, 15 Oct 2020 15:18:52 +0000 [thread overview]
Message-ID: <20201015111852.355049b1@gandalf.local.home> (raw)
In-Reply-To: <d489b145997147fd961050321b17d85d@bfs.de>
On Thu, 15 Oct 2020 15:12:53 +0000
Walter Harms <wharms@bfs.de> wrote:
> i guess the whole thing can be made more simple
>
> we have len and buflen
>
> len=strlen(filter->error_buffer);
> if (len >= buflen )
> return -1;
>
> strcpy(buf, filter->error_buffer);
>
Either is fine, but we are moving libtraceevent into it's own library,
which is located here:
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
-- Steve
prev parent reply other threads:[~2020-10-15 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:30 [PATCH] tools: net: traceevent: Fix 'snprintf' return value check in 'tep_filter_strerror' Fedor Tokarev
2020-10-15 15:12 ` AW: " Walter Harms
2020-10-15 15:18 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015111852.355049b1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@redhat.com \
--cc=ftokarev@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).