From: Stefano Garzarella <sgarzare@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vsock: fix the error return when an invalid ioctl command is used
Date: Tue, 27 Oct 2020 09:18:04 +0000 [thread overview]
Message-ID: <20201027091804.7mpad5yaxzfmbva6@steredhat> (raw)
In-Reply-To: <20201027090942.14916-3-colin.king@canonical.com>
On Tue, Oct 27, 2020 at 09:09:42AM +0000, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Currently when an invalid ioctl command is used the error return
>is -EINVAL. Fix this by returning the correct error -ENOIOCTLCMD.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> net/vmw_vsock/af_vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>index 865331b809e4..597c86413089 100644
>--- a/net/vmw_vsock/af_vsock.c
>+++ b/net/vmw_vsock/af_vsock.c
>@@ -2072,7 +2072,7 @@ static long vsock_dev_do_ioctl(struct file *filp,
> break;
>
> default:
>- retval = -EINVAL;
>+ retval = -ENOIOCTLCMD;
> }
>
> return retval;
>--
>2.27.0
>
next prev parent reply other threads:[~2020-10-27 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 9:09 [PATCH 0/2] vsock: minor clean up of ioctl error handling Colin King
2020-10-27 9:09 ` [PATCH 1/2][V2] vsock: remove ratelimit unknown ioctl message Colin King
2020-10-27 9:17 ` Stefano Garzarella
2020-10-27 9:09 ` [PATCH 2/2] vsock: fix the error return when an invalid ioctl command is used Colin King
2020-10-27 9:18 ` Stefano Garzarella [this message]
2020-10-30 0:45 ` [PATCH 0/2] vsock: minor clean up of ioctl error handling Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027091804.7mpad5yaxzfmbva6@steredhat \
--to=sgarzare@redhat.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).