From: Jakub Kicinski <kuba@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-safety@lists.elisa.tech
Subject: Re: [PATCH] ipv6: mcast: make annotations for ip6_mc_msfget() consistent
Date: Fri, 30 Oct 2020 20:59:48 +0000 [thread overview]
Message-ID: <20201030135948.32fc1a7c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201028115349.6855-1-lukas.bulwahn@gmail.com>
On Wed, 28 Oct 2020 12:53:49 +0100 Lukas Bulwahn wrote:
> Commit 931ca7ab7fe8 ("ip*_mc_gsfget(): lift copyout of struct group_filter
> into callers") adjusted the type annotations for ip6_mc_msfget() at its
> declaration, but missed the type annotations at its definition.
>
> Hence, sparse complains on ./net/ipv6/mcast.c:
>
> mcast.c:550:5: error: symbol 'ip6_mc_msfget' redeclared with different type \
> (incompatible argument 3 (different address spaces))
>
> Make ip6_mc_msfget() annotations consistent, which also resolves this
> warning from sparse:
>
> mcast.c:607:34: warning: incorrect type in argument 1 (different address spaces)
> mcast.c:607:34: expected void [noderef] __user *to
> mcast.c:607:34: got struct __kernel_sockaddr_storage *p
>
> No functional change. No change in object code.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Applied, thank you!
prev parent reply other threads:[~2020-10-30 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 11:53 [PATCH] ipv6: mcast: make annotations for ip6_mc_msfget() consistent Lukas Bulwahn
2020-10-30 20:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030135948.32fc1a7c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).