From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Cc: David Airlie <airlied@linux.ie>,
Edmund Dea <edmund.j.dea@intel.com>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] drm/kmb: Fix possible oops in probe error handling
Date: Tue, 17 Nov 2020 07:21:03 +0000 [thread overview]
Message-ID: <20201117072103.GA1111239@mwanda> (raw)
If kmb_dsi_init() fails the error handling will dereference an error
pointer which will cause an Oops.
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/kmb/kmb_drv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index a31a840ce634..8c43b136765c 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -504,7 +504,7 @@ static int kmb_probe(struct platform_device *pdev)
if (IS_ERR(kmb->kmb_dsi)) {
drm_err(&kmb->drm, "failed to initialize DSI\n");
ret = PTR_ERR(kmb->kmb_dsi);
- goto err_free1;
+ goto err_clear_drvdata;
}
kmb->kmb_dsi->dev = &dsi_pdev->dev;
@@ -540,8 +540,9 @@ static int kmb_probe(struct platform_device *pdev)
drm_crtc_cleanup(&kmb->crtc);
drm_mode_config_cleanup(&kmb->drm);
err_free1:
- dev_set_drvdata(dev, NULL);
kmb_dsi_host_unregister(kmb->kmb_dsi);
+ err_clear_drvdata:
+ dev_set_drvdata(dev, NULL);
return ret;
}
--
2.28.0
next reply other threads:[~2020-11-17 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 7:21 Dan Carpenter [this message]
2020-11-20 1:29 ` [PATCH] drm/kmb: Fix possible oops in probe error handling Chrisanthus, Anitha
2020-11-20 8:09 ` Dan Carpenter
2020-11-20 8:11 ` [PATCH v2] " Dan Carpenter
2020-11-20 22:15 ` Chrisanthus, Anitha
2020-11-30 7:48 ` Dan Carpenter
2020-12-03 1:11 ` Chrisanthus, Anitha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117072103.GA1111239@mwanda \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=anitha.chrisanthus@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).