* [PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer
@ 2020-12-07 14:24 Colin King
2020-12-07 15:51 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-12-07 14:24 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Alexandru Tachici, linux-hwmon
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are several occurrances of a less than zero error check on
a u32 unsigned integer. These will never be true. Fix this by making
reg_value a plain int.
Addresses-Coverity: ("Unsigned comparison against zero")
Fixes: e126370240e0 ("hwmon: (ltc2992) Add support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hwmon/ltc2992.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
index 69dbb5aa5dc2..4382105bf142 100644
--- a/drivers/hwmon/ltc2992.c
+++ b/drivers/hwmon/ltc2992.c
@@ -480,7 +480,7 @@ static int ltc2992_read_gpios_in(struct device *dev, u32 attr, int nr_gpio, long
static int ltc2992_read_in_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{
- u32 reg_val;
+ int reg_val;
u32 mask;
if (attr = hwmon_in_max_alarm)
@@ -534,7 +534,7 @@ static int ltc2992_read_in(struct device *dev, u32 attr, int channel, long *val)
static int ltc2992_get_current(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
{
- u32 reg_val;
+ int reg_val;
reg_val = ltc2992_read_reg(st, reg, 2);
if (reg_val < 0)
@@ -558,7 +558,7 @@ static int ltc2992_set_current(struct ltc2992_state *st, u32 reg, u32 channel, l
static int ltc2992_read_curr_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{
- u32 reg_val;
+ int reg_val;
u32 mask;
if (attr = hwmon_curr_max_alarm)
@@ -609,7 +609,7 @@ static int ltc2992_read_curr(struct device *dev, u32 attr, int channel, long *va
static int ltc2992_get_power(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
{
- u32 reg_val;
+ int reg_val;
reg_val = ltc2992_read_reg(st, reg, 3);
if (reg_val < 0)
@@ -633,7 +633,7 @@ static int ltc2992_set_power(struct ltc2992_state *st, u32 reg, u32 channel, lon
static int ltc2992_read_power_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{
- u32 reg_val;
+ int reg_val;
u32 mask;
if (attr = hwmon_power_max_alarm)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer
2020-12-07 14:24 [PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer Colin King
@ 2020-12-07 15:51 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-12-07 15:51 UTC (permalink / raw)
To: Colin King
Cc: Jean Delvare, Alexandru Tachici, linux-hwmon, kernel-janitors,
linux-kernel
On Mon, Dec 07, 2020 at 02:24:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are several occurrances of a less than zero error check on
> a u32 unsigned integer. These will never be true. Fix this by making
> reg_value a plain int.
>
> Addresses-Coverity: ("Unsigned comparison against zero")
> Fixes: e126370240e0 ("hwmon: (ltc2992) Add support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ltc2992.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 69dbb5aa5dc2..4382105bf142 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -480,7 +480,7 @@ static int ltc2992_read_gpios_in(struct device *dev, u32 attr, int nr_gpio, long
>
> static int ltc2992_read_in_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
> {
> - u32 reg_val;
> + int reg_val;
> u32 mask;
>
> if (attr = hwmon_in_max_alarm)
> @@ -534,7 +534,7 @@ static int ltc2992_read_in(struct device *dev, u32 attr, int channel, long *val)
>
> static int ltc2992_get_current(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
> {
> - u32 reg_val;
> + int reg_val;
>
> reg_val = ltc2992_read_reg(st, reg, 2);
> if (reg_val < 0)
> @@ -558,7 +558,7 @@ static int ltc2992_set_current(struct ltc2992_state *st, u32 reg, u32 channel, l
>
> static int ltc2992_read_curr_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
> {
> - u32 reg_val;
> + int reg_val;
> u32 mask;
>
> if (attr = hwmon_curr_max_alarm)
> @@ -609,7 +609,7 @@ static int ltc2992_read_curr(struct device *dev, u32 attr, int channel, long *va
>
> static int ltc2992_get_power(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
> {
> - u32 reg_val;
> + int reg_val;
>
> reg_val = ltc2992_read_reg(st, reg, 3);
> if (reg_val < 0)
> @@ -633,7 +633,7 @@ static int ltc2992_set_power(struct ltc2992_state *st, u32 reg, u32 channel, lon
>
> static int ltc2992_read_power_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
> {
> - u32 reg_val;
> + int reg_val;
> u32 mask;
>
> if (attr = hwmon_power_max_alarm)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-07 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 14:24 [PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer Colin King
2020-12-07 15:51 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).