From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Timur Tabi <timur@kernel.org>,
kernel-janitors@vger.kernel.org, Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ASoC: fsl: drop unneeded snd_soc_dai_set_drvdata
Date: Wed, 17 Feb 2021 22:30:39 -0800 [thread overview]
Message-ID: <20210218063038.GB13668@Asurada-Nvidia> (raw)
In-Reply-To: <20210213101907.1318496-5-Julia.Lawall@inria.fr>
On Sat, Feb 13, 2021 at 11:19:07AM +0100, Julia Lawall wrote:
> snd_soc_dai_set_drvdata is not needed when the set data comes from
> snd_soc_dai_get_drvdata or dev_get_drvdata. The problem was fixed
> usingthe following semantic patch: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,y,e;
> @@
> x = dev_get_drvdata(y->dev)
> ... when != x = e
> - snd_soc_dai_set_drvdata(y,x);
>
> @@
> expression x,y,e;
> @@
> x = snd_soc_dai_get_drvdata(y)
> ... when != x = e
> - snd_soc_dai_set_drvdata(y,x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
next prev parent reply other threads:[~2021-02-18 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 10:19 [PATCH 0/4] drop unneeded snd_soc_dai_set_drvdata Julia Lawall
2021-02-13 10:19 ` [PATCH 1/4] ASoC: mmp-sspa: " Julia Lawall
2021-02-13 10:19 ` [PATCH 2/4] ASoC: mxs-saif: " Julia Lawall
2021-02-13 10:19 ` [PATCH 3/4] ASoC: sun4i-i2s: " Julia Lawall
2021-02-13 10:19 ` [PATCH 4/4] ASoC: fsl: " Julia Lawall
2021-02-18 6:30 ` Nicolin Chen [this message]
2021-03-01 23:34 ` [PATCH 0/4] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218063038.GB13668@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).