* [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static
@ 2021-03-04 6:46 'Wei Yongjun
2021-03-05 6:00 ` Rafał Miłecki
2021-03-11 11:39 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: 'Wei Yongjun @ 2021-03-04 6:46 UTC (permalink / raw)
To: weiyongjun1, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Boris Brezillon, Rafał Miłecki
Cc: linux-mtd, linux-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/mtd/parsers/ofpart_core.c:25:32: warning:
symbol 'bcm4908_partitions_quirks' was not declared. Should it be static?
This symbol is not used outside of ofpart_core.c, so this
commit marks it static.
Fixes: 457da931b608 ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mtd/parsers/ofpart_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd/parsers/ofpart_core.c
index 258c06a42283..e9cb9ca28813 100644
--- a/drivers/mtd/parsers/ofpart_core.c
+++ b/drivers/mtd/parsers/ofpart_core.c
@@ -22,7 +22,7 @@ struct fixed_partitions_quirks {
int (*post_parse)(struct mtd_info *mtd, struct mtd_partition *parts, int nr_parts);
};
-struct fixed_partitions_quirks bcm4908_partitions_quirks = {
+static struct fixed_partitions_quirks bcm4908_partitions_quirks = {
.post_parse = bcm4908_partitions_post_parse,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static
2021-03-04 6:46 [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static 'Wei Yongjun
@ 2021-03-05 6:00 ` Rafał Miłecki
2021-03-11 11:39 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2021-03-05 6:00 UTC (permalink / raw)
To: 'Wei Yongjun, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Boris Brezillon
Cc: linux-mtd, linux-kernel, kernel-janitors, Hulk Robot
On 04.03.2021 07:46, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mtd/parsers/ofpart_core.c:25:32: warning:
> symbol 'bcm4908_partitions_quirks' was not declared. Should it be static?
>
> This symbol is not used outside of ofpart_core.c, so this
> commit marks it static.
>
> Fixes: 457da931b608 ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good ofc, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static
2021-03-04 6:46 [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static 'Wei Yongjun
2021-03-05 6:00 ` Rafał Miłecki
@ 2021-03-11 11:39 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2021-03-11 11:39 UTC (permalink / raw)
To: 'Wei Yongjun, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Boris Brezillon, Rafał Miłecki
Cc: linux-mtd, linux-kernel, kernel-janitors, Hulk Robot
On Thu, 2021-03-04 at 06:46:00 UTC, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mtd/parsers/ofpart_core.c:25:32: warning:
> symbol 'bcm4908_partitions_quirks' was not declared. Should it be static?
>
> This symbol is not used outside of ofpart_core.c, so this
> commit marks it static.
>
> Fixes: 457da931b608 ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 6:46 [PATCH -next] mtd: parsers: ofpart: make symbol 'bcm4908_partitions_quirks' static 'Wei Yongjun
2021-03-05 6:00 ` Rafał Miłecki
2021-03-11 11:39 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).