From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA30AC43461 for ; Fri, 7 May 2021 09:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EDEC6145A for ; Fri, 7 May 2021 09:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236152AbhEGJ22 (ORCPT ); Fri, 7 May 2021 05:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236023AbhEGJ22 (ORCPT ); Fri, 7 May 2021 05:28:28 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C3CC061574 for ; Fri, 7 May 2021 02:27:28 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lewlP-00023a-JO; Fri, 07 May 2021 11:27:15 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lewlN-0007ID-SU; Fri, 07 May 2021 11:27:13 +0200 Date: Fri, 7 May 2021 11:27:13 +0200 From: Michael Tretter To: Christophe JAILLET Cc: mturquette@baylibre.com, sboyd@kernel.org, michal.simek@xilinx.com, quanyang.wang@windriver.com, rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejasp@xilinx.com, shubhrajyoti.datta@xilinx.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code Message-ID: <20210507092713.GM29775@pengutronix.de> References: <71a9fed5f762a71248b8ac73c0a15af82f3ce1e2.1619867987.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <71a9fed5f762a71248b8ac73c0a15af82f3ce1e2.1619867987.git.christophe.jaillet@wanadoo.fr> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:22:09 up 78 days, 12:46, 97 users, load average: 0.07, 0.08, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: kernel-janitors@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Sat, 01 May 2021 13:24:32 +0200, Christophe JAILLET wrote: > 'clk_hw_set_rate_range()' does not return any error code and 'ret' is > known to be 0 at this point, so this message can never be displayed. > > Remove it. > > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Signed-off-by: Christophe JAILLET Reviewed-by: Michael Tretter > --- > HOWEVER, the message is about 'clk_set_rate_range()', not > 'clk_hw_set_rate_range()'. So the message is maybe correct and the > 'xxx_rate_range()' function incorrect. Thanks. The function is correct, as this is a clock provider and should use the clk_hw. Removing the message is correct. Michael > --- > drivers/clk/zynqmp/pll.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c > index abe6afbf3407..af11e9400058 100644 > --- a/drivers/clk/zynqmp/pll.c > +++ b/drivers/clk/zynqmp/pll.c > @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id, > } > > clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX); > - if (ret < 0) > - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret); > > return hw; > } > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >