From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09B8AC433B4 for ; Thu, 20 May 2021 03:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE56C61073 for ; Thu, 20 May 2021 03:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhETEAZ (ORCPT ); Thu, 20 May 2021 00:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbhETEAZ (ORCPT ); Thu, 20 May 2021 00:00:25 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B94CBC06175F for ; Wed, 19 May 2021 20:59:03 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so4553440pjv.1 for ; Wed, 19 May 2021 20:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5DmWgtEYdg1BAX4a133sojX2RWqI9f92J1In5aRH3J8=; b=iip6VP1d4MIfMedHTbkAptHJxqrSUnAIqGC7dGRCcrjrQbELrYHIkDluAkK0MQ5cEr zRPLkqHFZOLSGVoszfPe67PrUStgZmwxxWOHVNZmgo51kUXAYNSnjQ4BomzZh69gclI5 bZa1Rk/WkUhtMliRyFxtH+KIGlO8iRoVUc3STrBVAGHTu88l5WadziY3a4feqg3p5zZp GMTZwnKqO6Asrc3LCLB3EVQ379KWWGBxna0uiXV1qUfOHV/wMkBivJJC0SgkDcg4jhC/ zNJ3UA1nrqyWbUCtwrDSEkDp1hmOEdjrU1iXJQenDrC0PB7DbTmVRhmGQxh/TFrWpqzd tijQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5DmWgtEYdg1BAX4a133sojX2RWqI9f92J1In5aRH3J8=; b=VatBc4Els52Fkg9rO8IGCzsTmqJd+sB62VqMwEFpmLzHbJ3GNCA7hCBctUdRJkCQSy gzuLRVJyBfO+G0XUzdZCx6Rz12+6Kuq5yEPuGood/7G5K5fyuuuss4Eyt4Dd+lzzy076 yY9jyJdahQi5wliksIG2ZpE7oN+5j+A0wS+o6qad2sL4lPh5/ZJbzEVPvuQquF1VAUpN VvUVAfUpSSiPKl4++yqCoO1LbTANSkgFPT6FF+CTnZg2/YWIAguTkkInynVlXEIWcGdN O7i9c3RraUilib8cWmGxwiqCgWTNyOny4r59jnwcLOp2MSRc8bCpq/ilenrOcHyQQlty yMrw== X-Gm-Message-State: AOAM530/KMpbvw89iQqRdJngb3BgdgAHvP1vifn+3Pdeh1EyRGqnfUl3 T2RvgPs5wOZi1qlaKuJPGTcroA== X-Google-Smtp-Source: ABdhPJxDTwiOE6aXEMN09zlHVIX7YBPQdiLP9p/7O69S1nDvlDo4fbGKFAaHpPR1dF1D6nwZjtiGMA== X-Received: by 2002:a17:90a:1588:: with SMTP id m8mr3008221pja.226.1621483143208; Wed, 19 May 2021 20:59:03 -0700 (PDT) Received: from localhost ([136.185.154.93]) by smtp.gmail.com with ESMTPSA id l20sm731069pjq.38.2021.05.19.20.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 20:59:02 -0700 (PDT) Date: Thu, 20 May 2021 09:29:00 +0530 From: Viresh Kumar To: Christophe JAILLET Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, rjw@rjwysocki.net, nicola.mazzucato@arm.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] cpufreq: scmi: Fix an error message Message-ID: <20210520035900.5agxp6r6lwpdvl5i@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 06-05-21, 21:09, Christophe JAILLET wrote: > 'ret' is known to be 0 here. > The last error code is stored in 'nr_opp', so use it in the error message. > > Fixes: 71a37cd6a59d ("scmi-cpufreq: Remove deferred probe") > Signed-off-by: Christophe JAILLET > --- > drivers/cpufreq/scmi-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index c8a4364ad3c2..ec9a87ca2dbb 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -174,7 +174,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) > nr_opp = dev_pm_opp_get_opp_count(cpu_dev); > if (nr_opp <= 0) { > dev_err(cpu_dev, "%s: No OPPs for this device: %d\n", > - __func__, ret); > + __func__, nr_opp); > > ret = -ENODEV; > goto out_free_opp; Applied. Thanks. -- viresh