From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9FAC4743F for ; Tue, 8 Jun 2021 14:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 226A461287 for ; Tue, 8 Jun 2021 14:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233361AbhFHOaf (ORCPT ); Tue, 8 Jun 2021 10:30:35 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3801 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232911AbhFHOaS (ORCPT ); Tue, 8 Jun 2021 10:30:18 -0400 Received: from dggeml759-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Fzssw0SQszWsXc; Tue, 8 Jun 2021 22:23:32 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by dggeml759-chm.china.huawei.com (10.1.199.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 8 Jun 2021 22:28:22 +0800 From: Wei Yongjun To: , Arie Gershberg , Shai Malin , Ariel Elior , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg CC: , , , Hulk Robot Subject: [PATCH -next] nvme-tcp-offload: Fix error return code in nvme_tcp_ofld_setup_ctrl() Date: Tue, 8 Jun 2021 14:38:54 +0000 Message-ID: <20210608143854.4154005-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.102.38] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeml759-chm.china.huawei.com (10.1.199.138) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Fix to return negative error code -EINVAL if mandatory sgls are not supported. Fixes: 5aadd5f9311e ("nvme-tcp-offload: Add controller level implementation") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/nvme/host/tcp-offload.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/tcp-offload.c b/drivers/nvme/host/tcp-offload.c index c76822e5ada7..3879d5ed7497 100644 --- a/drivers/nvme/host/tcp-offload.c +++ b/drivers/nvme/host/tcp-offload.c @@ -622,6 +622,7 @@ static int nvme_tcp_ofld_setup_ctrl(struct nvme_ctrl *nctrl, bool new) if (!(nctrl->sgls & ((1 << 0) | (1 << 1)))) { dev_err(nctrl->device, "Mandatory sgls are not supported!\n"); + rc = -EINVAL; goto destroy_admin; }