From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DD6C48BCF for ; Wed, 9 Jun 2021 10:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ADE1613AC for ; Wed, 9 Jun 2021 10:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239012AbhFIKmU (ORCPT ); Wed, 9 Jun 2021 06:42:20 -0400 Received: from mail-ot1-f50.google.com ([209.85.210.50]:33508 "EHLO mail-ot1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236503AbhFIKmS (ORCPT ); Wed, 9 Jun 2021 06:42:18 -0400 Received: by mail-ot1-f50.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so9738756otl.0 for ; Wed, 09 Jun 2021 03:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KqX35mCyxhWCPmImmyUXFJ6q/RCRNm/UJq3q6VtoIW0=; b=L3bUf/YNw4EiSAx+NN0M/nD53ZmJuIViEpNAZe5oi/7bko+QO31e9HaJFXR6TYYaEF 0O6e4xkoum+yHa2sfj8I3PIsOsNnM916tu1XLYJvEk9tQ4btu2GH723pIthIyxxPaL9W Cs8an+Y5kQjE4urVDLUujhgj/Nh2YlbAG05if+nhZvJ74ypXtiPl61yzvIJaZ6qEPHnV AFeegMWfCCPGl/CMzJJ9esSEPEibqRx1eaal76CBVioJR+QcnDzRBsOWaMj4HcUZfV3z uGwTnVkKLf/+ppYiF3P1szB3mskDV8xP3T1r83Cel/o6WeduauQ9EsA3mRP4Ap6tgy1Z OelQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=KqX35mCyxhWCPmImmyUXFJ6q/RCRNm/UJq3q6VtoIW0=; b=c/tmtco+pvJvOefuCgHpX/0FEm61nRjTnbfSzZLugyo+ZSbNKkMRoKjvBCG5ulBVST /eL+0cZ7RFvlGrwvJYuARV+3EZ+hbio0Io8Dd8SOK1oUGn+9vKECuPCVS3wT9UX5md+x Pu0gcoVhq2JqPcobT/mJGmKt/14J9c8wLo8iXxHKcUfMig7nTcAPjBmL5MXPQKa75n61 Jb5JAW0G8Zl5QEYQDnrzvci+EZhsDz35+jIEvv4uujMTMpmKzpMp56UP7NP15S1V9Mk1 VfnL2lbnjbGQBbotb+EBODeWNaKU3gTLTuTPEEww1Ix2alVSB2FrZ+9VTWwd/3hcS4qr vbcA== X-Gm-Message-State: AOAM533TDTa6T0+e4VPV0qQRx5Fq06l8M9oxBMpyP4yvnMpsh481cq80 gCwXeXLiwvkPAIKReQI40hA= X-Google-Smtp-Source: ABdhPJw8b40nDyS0v6IDdycCWF4GVsok+GQSLMhcq1O4mflqt4iAfwBQ5f6wuLkaeNGiYG3aUBqawA== X-Received: by 2002:a05:6830:3089:: with SMTP id f9mr12607717ots.276.1623235164401; Wed, 09 Jun 2021 03:39:24 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id t26sm3754255oth.14.2021.06.09.03.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:39:23 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 9 Jun 2021 03:39:22 -0700 From: Guenter Roeck To: Dan Carpenter Cc: Larry Finger , Greg Kroah-Hartman , Michael Straube , Romain Perier , Allen Pais , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 7/7] staging: rtl8188eu: delete some dead code Message-ID: <20210609103922.GG3727184@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Mon, Jun 07, 2021 at 09:19:00PM +0300, Dan Carpenter wrote: > Calling rtw_free_xmitframe() with a NULL "pxmitframe" parameter is a > no-op. It appears that originally this code was part of a loop but it > was already dead code by the time that the driver was merged into the > kernel. > > Fixes: 7bc88639ad36 ("staging: r8188eu: Add files for new driver - part 17") > Signed-off-by: Dan Carpenter > --- > drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > index 19055a1a92c1..d82dd22f2903 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > @@ -413,8 +413,7 @@ static u32 xmitframe_need_length(struct xmit_frame *pxmitframe) > bool rtl8188eu_xmitframe_complete(struct adapter *adapt, > struct xmit_priv *pxmitpriv) > { > - struct xmit_frame *pxmitframe = NULL; > - struct xmit_frame *n; > + struct xmit_frame *pxmitframe, *n; > struct xmit_frame *pfirstframe = NULL; > struct xmit_buf *pxmitbuf; > > @@ -443,8 +442,6 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, > return false; > > /* 3 1. pick up first frame */ Comment could be removed as well. Otherwise, Thanks a lot for taking care of this, and sorry again for the mess I created. Reviewed-by: Guenter Roeck > - rtw_free_xmitframe(pxmitpriv, pxmitframe); > - > pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); > if (!pxmitframe) { > /* no more xmit frame, release xmit buffer */ > -- > 2.30.2 >