archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <>
To: Colin King <>
Cc: Andrew Lunn <>,
	Heiner Kallweit <>,
	Russell King <>,
	"David S . Miller" <>,
	Jakub Kicinski <>,,,
Subject: Re: [PATCH][next][V2] net: pcs: xpcs: Fix a less than zero u16 comparison error
Date: Tue, 15 Jun 2021 17:01:06 +0300	[thread overview]
Message-ID: <20210615140106.4qqygvptmx4yctwb@skbuf> (raw)
In-Reply-To: <>

On Tue, Jun 15, 2021 at 02:52:53PM +0100, Colin King wrote:
> From: Colin Ian King <>
> Currently the check for the u16 variable val being less than zero is
> always false because val is unsigned. Fix this by using the int
> variable for the assignment and less than zero check.
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: f7380bba42fd ("net: pcs: xpcs: add support for NXP SJA1110")
> Signed-off-by: Colin Ian King <>
> ---
> V2: Fix typo in subject and align the following 2 lines after the 
>     val = ret & ... assignment.  Thanks to Vladimir Oltean for spotting
>     these.
> ---


Reviewed-by: Vladimir Oltean <>

  reply	other threads:[~2021-06-15 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 13:52 [PATCH][next][V2] net: pcs: xpcs: Fix a less than zero u16 comparison error Colin King
2021-06-15 14:01 ` Vladimir Oltean [this message]
2021-06-17 18:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615140106.4qqygvptmx4yctwb@skbuf \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).