From: Maxime Ripard <maxime@cerno.tech>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Stephan Gerhold <stephan@gerhold.net>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static
Date: Wed, 16 Jun 2021 10:21:51 +0200 [thread overview]
Message-ID: <20210616082151.mrcbswfpponkleve@gilmour> (raw)
In-Reply-To: <20210615172156.2840576-1-weiyongjun1@huawei.com>
On Tue, Jun 15, 2021 at 05:21:56PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> sound/soc/codecs/hdmi-codec.c:750:25: warning:
> symbol 'hdmi_codec_controls' was not declared. Should it be static?
>
> This symbol is not used outside of hdmi-codec.c, so marks it static.
>
> Fixes: 366b45b97448 ("ASoC: hdmi-codec: Rework to support more controls")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Thanks!
Maxime
prev parent reply other threads:[~2021-06-16 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:21 [PATCH -next] ASoC: hdmi-codec: Make symbol 'hdmi_codec_controls' static Wei Yongjun
2021-06-16 8:21 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616082151.mrcbswfpponkleve@gilmour \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).