From: Corey Minyard <minyard@acm.org>
To: Colin King <colin.king@canonical.com>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
openipmi-developer@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int
Date: Wed, 16 Jun 2021 14:02:29 -0500 [thread overview]
Message-ID: <20210616190229.GG2921206@minyard.net> (raw)
In-Reply-To: <20210616162913.15259-1-colin.king@canonical.com>
On Wed, Jun 16, 2021 at 05:29:13PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The comparisons of the unsigned int hw_type to less than zero always
> false because it is unsigned. Fix this by using an int for the
> assignment and less than zero check.
Thanks, I added this to my tree.
-corey
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 9d2df9a0ad80 ("ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 0401089f8895..92a37b33494c 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -301,13 +301,15 @@ static inline int aspeed_kcs_map_serirq_type(u32 dt_type)
> static int aspeed_kcs_config_upstream_irq(struct aspeed_kcs_bmc *priv, u32 id, u32 dt_type)
> {
> unsigned int mask, val, hw_type;
> + int ret;
>
> if (id > 15)
> return -EINVAL;
>
> - hw_type = aspeed_kcs_map_serirq_type(dt_type);
> - if (hw_type < 0)
> - return hw_type;
> + ret = aspeed_kcs_map_serirq_type(dt_type);
> + if (ret < 0)
> + return ret;
> + hw_type = ret;
>
> priv->upstream_irq.mode = aspeed_kcs_irq_serirq;
> priv->upstream_irq.id = id;
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-06-16 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:29 [PATCH][next] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int Colin King
2021-06-16 19:02 ` Corey Minyard [this message]
2021-06-16 23:03 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616190229.GG2921206@minyard.net \
--to=minyard@acm.org \
--cc=andrew@aj.id.au \
--cc=colin.king@canonical.com \
--cc=joel@jms.id.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).