* [PATCH][next] opp: remove redundant continue statement
@ 2021-06-17 13:50 Colin King
2021-06-18 3:32 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-06-17 13:50 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The continue statement at the end of a for-loop has no effect,
remove it.
Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/opp/of.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 9573facce53a..d298e38aaf7e 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -197,10 +197,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
required_opp_tables[i] = _find_table_of_opp_np(required_np);
of_node_put(required_np);
- if (IS_ERR(required_opp_tables[i])) {
+ if (IS_ERR(required_opp_tables[i]))
lazy = true;
- continue;
- }
}
/* Let's do the linking later on */
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] opp: remove redundant continue statement
2021-06-17 13:50 [PATCH][next] opp: remove redundant continue statement Colin King
@ 2021-06-18 3:32 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2021-06-18 3:32 UTC (permalink / raw)
To: Colin King
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm,
kernel-janitors, linux-kernel
On 17-06-21, 14:50, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement at the end of a for-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/opp/of.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 9573facce53a..d298e38aaf7e 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -197,10 +197,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
> required_opp_tables[i] = _find_table_of_opp_np(required_np);
> of_node_put(required_np);
>
> - if (IS_ERR(required_opp_tables[i])) {
> + if (IS_ERR(required_opp_tables[i]))
> lazy = true;
> - continue;
> - }
> }
I had to merge this with:
"opp: Allow required-opps to be used for non genpd use cases"
Thanks for the report anyway :)
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 13:50 [PATCH][next] opp: remove redundant continue statement Colin King
2021-06-18 3:32 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).