From: Viresh Kumar <viresh.kumar@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] opp: remove redundant continue statement
Date: Fri, 18 Jun 2021 09:02:28 +0530 [thread overview]
Message-ID: <20210618033228.mork47zl3xydwb34@vireshk-i7> (raw)
In-Reply-To: <20210617135020.16415-1-colin.king@canonical.com>
On 17-06-21, 14:50, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The continue statement at the end of a for-loop has no effect,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/opp/of.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 9573facce53a..d298e38aaf7e 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -197,10 +197,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
> required_opp_tables[i] = _find_table_of_opp_np(required_np);
> of_node_put(required_np);
>
> - if (IS_ERR(required_opp_tables[i])) {
> + if (IS_ERR(required_opp_tables[i]))
> lazy = true;
> - continue;
> - }
> }
I had to merge this with:
"opp: Allow required-opps to be used for non genpd use cases"
Thanks for the report anyway :)
--
viresh
prev parent reply other threads:[~2021-06-18 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 13:50 [PATCH][next] opp: remove redundant continue statement Colin King
2021-06-18 3:32 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618033228.mork47zl3xydwb34@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).