archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <>
To: Dan Carpenter <>
Cc: Pablo Neira Ayuso <>,
	Jozsef Kadlecsik <>,
	Florian Westphal <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,,,,
Subject: Re: [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow
Date: Sun, 20 Jun 2021 22:45:38 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <YM33YmacZTH820Cv@mwanda>

Dan Carpenter <> wrote:
> The kernel version of snprintf() can't return negatives.  The
> "ret > (int)sizeof(sym)" check is off by one because and it should be
> >=.  Finally, we need to set a negative error code.

Reviewed-by: Florian Westphal <>

  reply	other threads:[~2021-06-20 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 13:55 [PATCH net-next] netfilter: nfnetlink_hook: fix check for snprintf() overflow Dan Carpenter
2021-06-20 20:45 ` Florian Westphal [this message]
2021-06-21 20:06 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).