kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] paride: remove redudant space character check
@ 2021-07-02 11:11 Colin King
  0 siblings, 0 replies; only message in thread
From: Colin King @ 2021-07-02 11:11 UTC (permalink / raw)
  To: tim, Jens Axboe, linux-block; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The check for variable l being a space character is always false, l can
never be a space character. The check is redundant and can be removed.

Addresses-Coverity: ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/block/paride/pg.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/paride/pg.c b/drivers/block/paride/pg.c
index 3b5882bfb736..2f7aa8521395 100644
--- a/drivers/block/paride/pg.c
+++ b/drivers/block/paride/pg.c
@@ -429,8 +429,6 @@ static void xs(char *buf, char *targ, int len)
 		if (c != ' ' && c != l)
 			l = *targ++ = c;
 	}
-	if (l == ' ')
-		targ--;
 	*targ = '\0';
 }
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-02 11:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 11:11 [PATCH] paride: remove redudant space character check Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).