* [PATCH] platform/x86: ISST: use semi-colons instead of commas
@ 2021-08-25 7:23 Dan Carpenter
2021-08-25 11:02 ` Srinivas Pandruvada
2021-08-26 13:18 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-08-25 7:23 UTC (permalink / raw)
To: Srinivas Pandruvada
Cc: Hans de Goede, Mark Gross, platform-driver-x86, kernel-janitors
The code works the same either way, but it's better to use semi-colons
to separate statements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
index 8a4d52a9028d..c9a85eb2e860 100644
--- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
@@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user *argp)
{
struct isst_if_platform_info info;
- info.api_version = ISST_IF_API_VERSION,
- info.driver_version = ISST_IF_DRIVER_VERSION,
- info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
+ info.api_version = ISST_IF_API_VERSION;
+ info.driver_version = ISST_IF_DRIVER_VERSION;
+ info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
info.mbox_supported = punit_callbacks[ISST_IF_DEV_MBOX].registered;
info.mmio_supported = punit_callbacks[ISST_IF_DEV_MMIO].registered;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: ISST: use semi-colons instead of commas
2021-08-25 7:23 [PATCH] platform/x86: ISST: use semi-colons instead of commas Dan Carpenter
@ 2021-08-25 11:02 ` Srinivas Pandruvada
2021-08-26 13:18 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2021-08-25 11:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hans de Goede, Mark Gross, platform-driver-x86, kernel-janitors
On Wed, 2021-08-25 at 10:23 +0300, Dan Carpenter wrote:
> The code works the same either way, but it's better to use semi-
> colons
> to separate statements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> index 8a4d52a9028d..c9a85eb2e860 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user
> *argp)
> {
> struct isst_if_platform_info info;
>
> - info.api_version = ISST_IF_API_VERSION,
> - info.driver_version = ISST_IF_DRIVER_VERSION,
> - info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
> + info.api_version = ISST_IF_API_VERSION;
> + info.driver_version = ISST_IF_DRIVER_VERSION;
> + info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
> info.mbox_supported =
> punit_callbacks[ISST_IF_DEV_MBOX].registered;
> info.mmio_supported =
> punit_callbacks[ISST_IF_DEV_MMIO].registered;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: ISST: use semi-colons instead of commas
2021-08-25 7:23 [PATCH] platform/x86: ISST: use semi-colons instead of commas Dan Carpenter
2021-08-25 11:02 ` Srinivas Pandruvada
@ 2021-08-26 13:18 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-08-26 13:18 UTC (permalink / raw)
To: Dan Carpenter, Srinivas Pandruvada
Cc: Mark Gross, platform-driver-x86, kernel-janitors
Hi,
On 8/25/21 9:23 AM, Dan Carpenter wrote:
> The code works the same either way, but it's better to use semi-colons
> to separate statements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> index 8a4d52a9028d..c9a85eb2e860 100644
> --- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -265,9 +265,9 @@ static int isst_if_get_platform_info(void __user *argp)
> {
> struct isst_if_platform_info info;
>
> - info.api_version = ISST_IF_API_VERSION,
> - info.driver_version = ISST_IF_DRIVER_VERSION,
> - info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT,
> + info.api_version = ISST_IF_API_VERSION;
> + info.driver_version = ISST_IF_DRIVER_VERSION;
> + info.max_cmds_per_ioctl = ISST_IF_CMD_LIMIT;
> info.mbox_supported = punit_callbacks[ISST_IF_DEV_MBOX].registered;
> info.mmio_supported = punit_callbacks[ISST_IF_DEV_MMIO].registered;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-26 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 7:23 [PATCH] platform/x86: ISST: use semi-colons instead of commas Dan Carpenter
2021-08-25 11:02 ` Srinivas Pandruvada
2021-08-26 13:18 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).