kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: remove rmd320 in Makefile
@ 2021-08-16 12:44 Lukas Bulwahn
  2021-08-16 12:55 ` Ard Biesheuvel
  2021-08-27  8:35 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2021-08-16 12:44 UTC (permalink / raw)
  To: Herbert Xu, David S . Miller, Ard Biesheuvel, linux-crypto
  Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
removes the Kconfig and code, but misses to adjust the Makefile.

Hence, ./scripts/checkkconfigsymbols.py warns:

CRYPTO_RMD320
Referencing files: crypto/Makefile

Remove the missing piece of this code removal.

Fixes: 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 crypto/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/crypto/Makefile b/crypto/Makefile
index 10526d4559b8..c633f15a0481 100644
--- a/crypto/Makefile
+++ b/crypto/Makefile
@@ -74,7 +74,6 @@ obj-$(CONFIG_CRYPTO_NULL2) += crypto_null.o
 obj-$(CONFIG_CRYPTO_MD4) += md4.o
 obj-$(CONFIG_CRYPTO_MD5) += md5.o
 obj-$(CONFIG_CRYPTO_RMD160) += rmd160.o
-obj-$(CONFIG_CRYPTO_RMD320) += rmd320.o
 obj-$(CONFIG_CRYPTO_SHA1) += sha1_generic.o
 obj-$(CONFIG_CRYPTO_SHA256) += sha256_generic.o
 obj-$(CONFIG_CRYPTO_SHA512) += sha512_generic.o
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: remove rmd320 in Makefile
  2021-08-16 12:44 [PATCH] crypto: remove rmd320 in Makefile Lukas Bulwahn
@ 2021-08-16 12:55 ` Ard Biesheuvel
  2021-08-27  8:35 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2021-08-16 12:55 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Herbert Xu, David S . Miller, Linux Crypto Mailing List,
	kernel-janitors, Linux Kernel Mailing List

On Mon, 16 Aug 2021 at 14:44, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> removes the Kconfig and code, but misses to adjust the Makefile.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> CRYPTO_RMD320
> Referencing files: crypto/Makefile
>
> Remove the missing piece of this code removal.
>
> Fixes: 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  crypto/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/crypto/Makefile b/crypto/Makefile
> index 10526d4559b8..c633f15a0481 100644
> --- a/crypto/Makefile
> +++ b/crypto/Makefile
> @@ -74,7 +74,6 @@ obj-$(CONFIG_CRYPTO_NULL2) += crypto_null.o
>  obj-$(CONFIG_CRYPTO_MD4) += md4.o
>  obj-$(CONFIG_CRYPTO_MD5) += md5.o
>  obj-$(CONFIG_CRYPTO_RMD160) += rmd160.o
> -obj-$(CONFIG_CRYPTO_RMD320) += rmd320.o
>  obj-$(CONFIG_CRYPTO_SHA1) += sha1_generic.o
>  obj-$(CONFIG_CRYPTO_SHA256) += sha256_generic.o
>  obj-$(CONFIG_CRYPTO_SHA512) += sha512_generic.o
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: remove rmd320 in Makefile
  2021-08-16 12:44 [PATCH] crypto: remove rmd320 in Makefile Lukas Bulwahn
  2021-08-16 12:55 ` Ard Biesheuvel
@ 2021-08-27  8:35 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2021-08-27  8:35 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: David S . Miller, Ard Biesheuvel, linux-crypto, kernel-janitors,
	linux-kernel

On Mon, Aug 16, 2021 at 02:44:33PM +0200, Lukas Bulwahn wrote:
> Commit 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> removes the Kconfig and code, but misses to adjust the Makefile.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
> CRYPTO_RMD320
> Referencing files: crypto/Makefile
> 
> Remove the missing piece of this code removal.
> 
> Fixes: 93f64202926f ("crypto: rmd320 - remove RIPE-MD 320 hash algorithm")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  crypto/Makefile | 1 -
>  1 file changed, 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-27  8:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 12:44 [PATCH] crypto: remove rmd320 in Makefile Lukas Bulwahn
2021-08-16 12:55 ` Ard Biesheuvel
2021-08-27  8:35 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).