kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: gyro: remove dead config dependencies on INPUT_MPU3050
@ 2021-08-17  8:13 Lukas Bulwahn
  2021-08-17 20:11 ` Linus Walleij
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2021-08-17  8:13 UTC (permalink / raw)
  To: Jonathan Cameron, Lars-Peter Clausen, linux-iio
  Cc: Linus Walleij, kernel-janitors, linux-kernel, Lukas Bulwahn

Commit b1fe0cf06f92 ("Input: delete MPU3050 driver") deletes the superseded
MPU3050 driver and its corresponding config INPUT_MPU3050.

The dependencies on the superseding driver in ./drivers/iio/gyro/Kconfig
to ensure that the two drivers are not built into the same kernel is a dead
dependency and not required anymore.

So, remove those config dependencies on INPUT_MPU3050 for MPU3050_I2C.

This issue was detected with ./scripts/checkkconfigsymbols.py.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/iio/gyro/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig
index 20b5ac7ab66a..a672f7d12bbb 100644
--- a/drivers/iio/gyro/Kconfig
+++ b/drivers/iio/gyro/Kconfig
@@ -126,7 +126,6 @@ config MPU3050
 
 config MPU3050_I2C
 	tristate "Invensense MPU3050 devices on I2C"
-	depends on !(INPUT_MPU3050=y || INPUT_MPU3050=m)
 	depends on I2C
 	select MPU3050
 	select REGMAP_I2C
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: gyro: remove dead config dependencies on INPUT_MPU3050
  2021-08-17  8:13 [PATCH] iio: gyro: remove dead config dependencies on INPUT_MPU3050 Lukas Bulwahn
@ 2021-08-17 20:11 ` Linus Walleij
  2021-08-29 15:47   ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2021-08-17 20:11 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Jonathan Cameron, Lars-Peter Clausen, linux-iio, kernel-janitors,
	linux-kernel

On Tue, Aug 17, 2021 at 10:13 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> Commit b1fe0cf06f92 ("Input: delete MPU3050 driver") deletes the superseded
> MPU3050 driver and its corresponding config INPUT_MPU3050.
>
> The dependencies on the superseding driver in ./drivers/iio/gyro/Kconfig
> to ensure that the two drivers are not built into the same kernel is a dead
> dependency and not required anymore.
>
> So, remove those config dependencies on INPUT_MPU3050 for MPU3050_I2C.
>
> This issue was detected with ./scripts/checkkconfigsymbols.py.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Oops my leftover.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: gyro: remove dead config dependencies on INPUT_MPU3050
  2021-08-17 20:11 ` Linus Walleij
@ 2021-08-29 15:47   ` Jonathan Cameron
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-08-29 15:47 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Lukas Bulwahn, Lars-Peter Clausen, linux-iio, kernel-janitors,
	linux-kernel

On Tue, 17 Aug 2021 22:11:36 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Aug 17, 2021 at 10:13 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> 
> > Commit b1fe0cf06f92 ("Input: delete MPU3050 driver") deletes the superseded
> > MPU3050 driver and its corresponding config INPUT_MPU3050.
> >
> > The dependencies on the superseding driver in ./drivers/iio/gyro/Kconfig
> > to ensure that the two drivers are not built into the same kernel is a dead
> > dependency and not required anymore.
> >
> > So, remove those config dependencies on INPUT_MPU3050 for MPU3050_I2C.
> >
> > This issue was detected with ./scripts/checkkconfigsymbols.py.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>  
> 
> Oops my leftover.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij

Applied,

Thanks,


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-29 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17  8:13 [PATCH] iio: gyro: remove dead config dependencies on INPUT_MPU3050 Lukas Bulwahn
2021-08-17 20:11 ` Linus Walleij
2021-08-29 15:47   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).