kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iio: dac: fix an error code in probe()
@ 2021-08-16 18:39 Dan Carpenter
  2021-08-29 15:56 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-08-16 18:39 UTC (permalink / raw)
  To: Jonathan Cameron, Sean Nyekjaer
  Cc: Lars-Peter Clausen, Vincent Whitchurch, linux-iio, kernel-janitors

If we have an unexpected number of channels then return -EINVAL instead
of returning success.

Fixes: df38a4a72a3b ("iio: dac: add TI DAC5571 family support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/iio/dac/ti-dac5571.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index 2a5ba1b08a1d..546a4cf6c5ef 100644
--- a/drivers/iio/dac/ti-dac5571.c
+++ b/drivers/iio/dac/ti-dac5571.c
@@ -350,6 +350,7 @@ static int dac5571_probe(struct i2c_client *client,
 		data->dac5571_pwrdwn = dac5571_pwrdwn_quad;
 		break;
 	default:
+		ret = -EINVAL;
 		goto err;
 	}
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: dac: fix an error code in probe()
  2021-08-16 18:39 [PATCH] iio: dac: fix an error code in probe() Dan Carpenter
@ 2021-08-29 15:56 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-08-29 15:56 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Sean Nyekjaer, Lars-Peter Clausen, Vincent Whitchurch, linux-iio,
	kernel-janitors

On Mon, 16 Aug 2021 21:39:54 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> If we have an unexpected number of channels then return -EINVAL instead
> of returning success.
> 
> Fixes: df38a4a72a3b ("iio: dac: add TI DAC5571 family support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Given I'm not going to be doing another fixes pull for 5.14 (bit late afterall!)
I've rebased the fixes-togreg branch to match staging/staging-next which will
go in during the merge window + applied this on top.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ti-dac5571.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index 2a5ba1b08a1d..546a4cf6c5ef 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -350,6 +350,7 @@ static int dac5571_probe(struct i2c_client *client,
>  		data->dac5571_pwrdwn = dac5571_pwrdwn_quad;
>  		break;
>  	default:
> +		ret = -EINVAL;
>  		goto err;
>  	}
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-29 15:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 18:39 [PATCH] iio: dac: fix an error code in probe() Dan Carpenter
2021-08-29 15:56 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).