archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Andrey Ignatov <>
Cc:, Jakub Kicinski <>
Subject: Re: [bug report] rtnetlink: Return correct error on changing device netns
Date: Tue, 31 Aug 2021 12:03:04 +0300	[thread overview]
Message-ID: <20210831090304.GN12231@kadam> (raw)
In-Reply-To: <>

Thanks.  In theory, Smatch is supposed to be able to parse this
correctly but do_setlink() is too complicated for Smatch.

net/core/rtnetlink.c:2824 do_setlink() warn: Function too hairy.  No more merges.

So then the callers think that ifm->ifi_index is not used and they don't
pass that information.  It's hard to know how to fix this...

dan carpenter

      reply	other threads:[~2021-08-31  9:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  9:04 Dan Carpenter
2021-08-31  7:06 ` Andrey Ignatov
2021-08-31  9:03   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210831090304.GN12231@kadam \ \ \ \ \
    --subject='Re: [bug report] rtnetlink: Return correct error on changing device netns' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).