* [PATCH][next] media: pvrusb2: add newline between two statements
@ 2021-09-02 22:01 Colin King
2021-09-02 22:02 ` NAK: " Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2021-09-02 22:01 UTC (permalink / raw)
To: Mike Isely, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are two statements on the same line, add a newline to clean
this up.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index d38dee1792e4..ca00b7fe1e7f 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
enable_flag ? "enable" : "disable");
}
pvr2_hdw_state_sched(hdw);
- } while (0); LOCK_GIVE(hdw->big_lock);
+ } while (0);
+ LOCK_GIVE(hdw->big_lock);
if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
if (enable_flag) {
while ((st = hdw->master_state) != PVR2_STATE_RUN) {
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* NAK: [PATCH][next] media: pvrusb2: add newline between two statements
2021-09-02 22:01 [PATCH][next] media: pvrusb2: add newline between two statements Colin King
@ 2021-09-02 22:02 ` Colin Ian King
2021-09-13 11:00 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2021-09-02 22:02 UTC (permalink / raw)
To: Mike Isely, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
On 02/09/2021 23:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are two statements on the same line, add a newline to clean
> this up.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> index d38dee1792e4..ca00b7fe1e7f 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
> enable_flag ? "enable" : "disable");
> }
> pvr2_hdw_state_sched(hdw);
> - } while (0); LOCK_GIVE(hdw->big_lock);
> + } while (0);
> + LOCK_GIVE(hdw->big_lock);
> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
> if (enable_flag) {
> while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>
ignore, V2 being sent in a moment.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements
2021-09-02 22:02 ` NAK: " Colin Ian King
@ 2021-09-13 11:00 ` Hans Verkuil
2021-09-13 11:04 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2021-09-13 11:00 UTC (permalink / raw)
To: Colin Ian King, Mike Isely, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
On 03/09/2021 00:02, Colin Ian King wrote:
> On 02/09/2021 23:01, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two statements on the same line, add a newline to clean
>> this up.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> index d38dee1792e4..ca00b7fe1e7f 100644
>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
>> enable_flag ? "enable" : "disable");
>> }
>> pvr2_hdw_state_sched(hdw);
>> - } while (0); LOCK_GIVE(hdw->big_lock);
>> + } while (0);
>> + LOCK_GIVE(hdw->big_lock);
>> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
>> if (enable_flag) {
>> while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>>
>
> ignore, V2 being sent in a moment.
I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: NAK: [PATCH][next] media: pvrusb2: add newline between two statements
2021-09-13 11:00 ` Hans Verkuil
@ 2021-09-13 11:04 ` Colin Ian King
0 siblings, 0 replies; 4+ messages in thread
From: Colin Ian King @ 2021-09-13 11:04 UTC (permalink / raw)
To: Hans Verkuil, Mike Isely, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
On 13/09/2021 12:00, Hans Verkuil wrote:
> On 03/09/2021 00:02, Colin Ian King wrote:
>> On 02/09/2021 23:01, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> There are two statements on the same line, add a newline to clean
>>> this up.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> index d38dee1792e4..ca00b7fe1e7f 100644
>>> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>>> @@ -1727,7 +1727,8 @@ int pvr2_hdw_set_streaming(struct pvr2_hdw *hdw,int enable_flag)
>>> enable_flag ? "enable" : "disable");
>>> }
>>> pvr2_hdw_state_sched(hdw);
>>> - } while (0); LOCK_GIVE(hdw->big_lock);
>>> + } while (0);
>>> + LOCK_GIVE(hdw->big_lock);
>>> if ((ret = pvr2_hdw_wait(hdw,0)) < 0) return ret;
>>> if (enable_flag) {
>>> while ((st = hdw->master_state) != PVR2_STATE_RUN) {
>>>
>>
>> ignore, V2 being sent in a moment.
>
> I haven't seen a V2 yet... In any case, I've rejected this patch in patchwork.
After looking at all the unconventional code style issues I chose not to
clean this up.
>
> Regards,
>
> Hans
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-13 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-02 22:01 [PATCH][next] media: pvrusb2: add newline between two statements Colin King
2021-09-02 22:02 ` NAK: " Colin Ian King
2021-09-13 11:00 ` Hans Verkuil
2021-09-13 11:04 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).