* [PATCH][next] hwmon: (mlxreg-fan): Fix out of bounds read on array fan->pwm
@ 2021-09-20 18:09 Colin King
2021-09-24 1:06 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-09-20 18:09 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Vadim Pasternak, linux-hwmon
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Array fan->pwm[] is MLXREG_FAN_MAX_PWM elements in size, however the
for-loop has a off-by-one error causing index i to be out of range
causing an out of bounds read on the array. Fix this by replacing
the <= operator with < in the for-loop.
Addresses-Coverity: ("Out-of-bounds read")
Fixes: 35edbaab3bbf ("hwmon: (mlxreg-fan) Extend driver to support multiply cooling devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hwmon/mlxreg-fan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
index 35228ed112d7..feab9ec6a6ca 100644
--- a/drivers/hwmon/mlxreg-fan.c
+++ b/drivers/hwmon/mlxreg-fan.c
@@ -554,7 +554,7 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan)
{
int i, j;
- for (i = 0; i <= MLXREG_FAN_MAX_PWM; i++) {
+ for (i = 0; i < MLXREG_FAN_MAX_PWM; i++) {
struct mlxreg_fan_pwm *pwm = &fan->pwm[i];
if (!pwm->connected)
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] hwmon: (mlxreg-fan): Fix out of bounds read on array fan->pwm
2021-09-20 18:09 [PATCH][next] hwmon: (mlxreg-fan): Fix out of bounds read on array fan->pwm Colin King
@ 2021-09-24 1:06 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-24 1:06 UTC (permalink / raw)
To: Colin King
Cc: Jean Delvare, Vadim Pasternak, linux-hwmon, kernel-janitors,
linux-kernel
On Mon, Sep 20, 2021 at 07:09:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array fan->pwm[] is MLXREG_FAN_MAX_PWM elements in size, however the
> for-loop has a off-by-one error causing index i to be out of range
> causing an out of bounds read on the array. Fix this by replacing
> the <= operator with < in the for-loop.
>
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes: 35edbaab3bbf ("hwmon: (mlxreg-fan) Extend driver to support multiply cooling devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/mlxreg-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
> index 35228ed112d7..feab9ec6a6ca 100644
> --- a/drivers/hwmon/mlxreg-fan.c
> +++ b/drivers/hwmon/mlxreg-fan.c
> @@ -554,7 +554,7 @@ static int mlxreg_fan_cooling_config(struct device *dev, struct mlxreg_fan *fan)
> {
> int i, j;
>
> - for (i = 0; i <= MLXREG_FAN_MAX_PWM; i++) {
> + for (i = 0; i < MLXREG_FAN_MAX_PWM; i++) {
> struct mlxreg_fan_pwm *pwm = &fan->pwm[i];
>
> if (!pwm->connected)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-24 1:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 18:09 [PATCH][next] hwmon: (mlxreg-fan): Fix out of bounds read on array fan->pwm Colin King
2021-09-24 1:06 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).