From: SeongJae Park <sj@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL
Date: Sun, 26 Sep 2021 05:45:39 +0000 [thread overview]
Message-ID: <20210926054539.11630-1-sj@kernel.org> (raw)
In-Reply-To: <20210925215908.181226-1-colin.king@canonical.com>
Hello Colin, thank you for the patch!
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a plain integer is being used to nullify the
> pointer ctx->kdamond. Use NULL instead. Cleans up sparse
> warning:
>
> mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> mm/damon/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 874558a790a0..c8665c80577a 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
> nr_running_ctxs);
> if (IS_ERR(ctx->kdamond)) {
> err = PTR_ERR(ctx->kdamond);
> - ctx->kdamond = 0;
> + ctx->kdamond = NULL;
> }
> }
> mutex_unlock(&ctx->kdamond_lock);
> --
> 2.32.0
prev parent reply other threads:[~2021-09-26 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 21:59 [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL Colin King
2021-09-26 5:45 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926054539.11630-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).