kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colin Ian King <colin.i.king@gmail.com>
To: Evgeniy Dushistov <dushistov@mail.ru>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ufs: Remove redundant assignment to pointer p
Date: Mon, 10 Oct 2022 21:47:43 +0100	[thread overview]
Message-ID: <20221010204743.3224265-1-colin.i.king@gmail.com> (raw)

The pointer p is being assigned a new value that is never read. The
assignment is redundant and can be removed.

Cleans up clang scan-build warning:
fs/ufs/dir.c:179:2: warning: Value stored to 'p' is never read
[deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/ufs/dir.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c
index 391efaf1d528..bf19cd882965 100644
--- a/fs/ufs/dir.c
+++ b/fs/ufs/dir.c
@@ -176,7 +176,6 @@ static bool ufs_check_page(struct page *page)
 		   rec_len, ufs_get_de_namlen(sb, p));
 	goto fail;
 Eend:
-	p = (struct ufs_dir_entry *)(kaddr + offs);
 	ufs_error(sb, __func__,
 		   "entry in directory #%lu spans the page boundary"
 		   "offset=%lu",
-- 
2.37.3


             reply	other threads:[~2022-10-10 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 20:47 Colin Ian King [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-13 13:41 [PATCH] ufs: remove redundant assignment to pointer p Colin King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221010204743.3224265-1-colin.i.king@gmail.com \
    --to=colin.i.king@gmail.com \
    --cc=dushistov@mail.ru \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).