From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Date: Tue, 22 Sep 2020 12:50:12 +0000 Subject: Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check Message-Id: <22b12b8a-4c16-5377-043d-00750597f822@canonical.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jim Quinlan , Markus Elfring Cc: Rob Herring , Florian Fainelli , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , kernel-janitors@vger.kernel.org, open list , Nicolas Saenz Julienne , Lorenzo Pieralisi , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Bjorn Helgaas , Jim Quinlan , Alex Dewar , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" On 22/09/2020 13:43, Jim Quinlan wrote: > On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring wrote: >> >>> The error return ret is not being check with an if statement and >> >> Wording alternative: >> The return value from a call of the function “brcm_phy_start” was not checked and >> >> >>> V2: disable clock as noted by Florian Fainelli and suggested by >>> Jim Quinlan. >> >> Alex Dewar contributed another update suggestion. >> >> [PATCH v2] PCI: brcmstb: Add missing if statement and error path >> https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@gmail.com/ >> https://lore.kernel.org/patchwork/patch/1309860/ >> >> The exception handling needs further development considerations >> for this function implementation. > Hello, > > I agree with Alex's patch. I should have suggested this at the > beginning but as our upstream STB suspend/resume is not yet functional > and the one-line change would have worked until we fixed > suspend/resume.. But this is the proper modification. Yup, go with Alex's patch. That one is correct. > > Thanks, > Jim >> Regards, >> Markus