From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Kari Argillander <kari.argillander@gmail.com>,
Colin King <colin.king@canonical.com>
Cc: <ntfs3@lists.linux.dev>, <kernel-janitors@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] fs/ntfs3: Fix a memory leak on object opts
Date: Mon, 20 Sep 2021 19:12:56 +0300 [thread overview]
Message-ID: <2692afd4-f263-838a-a80e-e6f740d44f36@paragon-software.com> (raw)
In-Reply-To: <20210910105018.asvmzihjdqeqm25v@kari-VirtualBox>
On 10.09.2021 13:50, Kari Argillander wrote:
> On Fri, Sep 10, 2021 at 11:02:02AM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently a failed allocation on sbi->upcase will cause an exit via
>> the label free_sbi causing a memory leak on object opts. Fix this by
>> re-ordering the exit paths free_opts and free_sbi so that kfree's occur
>> in the reverse allocation order.
>>
>> Addresses-Coverity: ("Resource leak")
>> Fixes: 27fac77707a1 ("fs/ntfs3: Init spi more in init_fs_context than fill_super")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>
> Thanks Colin.
>
> Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
>
>> fs/ntfs3/super.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
>> index 3cba0b5e7ac7..69f23db0d727 100644
>> --- a/fs/ntfs3/super.c
>> +++ b/fs/ntfs3/super.c
>> @@ -1450,10 +1450,10 @@ static int ntfs_init_fs_context(struct fs_context *fc)
>> fc->ops = &ntfs_context_ops;
>>
>> return 0;
>> -free_opts:
>> - kfree(opts);
>> free_sbi:
>> kfree(sbi);
>> +free_opts:
>> + kfree(opts);
>> return -ENOMEM;
>> }
>>
>> --
>> 2.32.0
>>
Hi, Colin, Kari!
Thanks for work - applied!
prev parent reply other threads:[~2021-09-20 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 10:02 [PATCH][next] fs/ntfs3: Fix a memory leak on object opts Colin King
2021-09-10 10:50 ` Kari Argillander
2021-09-20 16:12 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2692afd4-f263-838a-a80e-e6f740d44f36@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=colin.king@canonical.com \
--cc=kari.argillander@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).