* Re: [PATCH v2] nfc: nci: add missed destroy_workqueue in nci_register_device
@ 2020-07-17 7:47 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-07-17 7:47 UTC (permalink / raw)
To: Wang Hai, netdev
Cc: kernel-janitors, linux-kernel, Vincent Cuissard, Samuel Ortiz,
Jakub Kicinski, David S. Miller
> When nfc_register_device fails in nci_register_device,
> destroy_workqueue() shouled be called to destroy ndev->tx_wq.
Would an other imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f8456690ba8eb18ea4714e68554e242a04f65cff#n151
…
> +++ b/net/nfc/nci/core.c
> @@ -1228,10 +1228,13 @@ int nci_register_device(struct nci_dev *ndev)
>
> rc = nfc_register_device(ndev->nfc_dev);
> if (rc)
> - goto destroy_rx_wq_exit;
> + goto destroy_tx_wq_exit;
>
> goto exit;
>
> +destroy_tx_wq_exit:
> + destroy_workqueue(ndev->tx_wq);
…
How do you think about to use the following source code variant
for this function implementation?
if (!rc)
goto exit;
destroy_workqueue(ndev->tx_wq);
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-17 7:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 7:47 [PATCH v2] nfc: nci: add missed destroy_workqueue in nci_register_device Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).