From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1659C11F64 for ; Thu, 1 Jul 2021 17:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB42F613CF for ; Thu, 1 Jul 2021 17:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233265AbhGARpX (ORCPT ); Thu, 1 Jul 2021 13:45:23 -0400 Received: from smtp06.smtpout.orange.fr ([80.12.242.128]:57370 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233194AbhGARpX (ORCPT ); Thu, 1 Jul 2021 13:45:23 -0400 Received: from [192.168.1.18] ([86.243.172.93]) by mwinf5d12 with ME id Ptip2500321Fzsu03tip3W; Thu, 01 Jul 2021 19:42:51 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 01 Jul 2021 19:42:51 +0200 X-ME-IP: 86.243.172.93 Subject: Re: [PATCH 0/3] gve: Fixes and clean-up To: Jeroen de Borst Cc: csully@google.com, sagis@google.com, jonolson@google.com, davem@davemloft.net, kuba@kernel.org, awogbemila@google.com, willemb@google.com, yangchun@google.com, bcf@google.com, kuozhao@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Christophe JAILLET Message-ID: <29632746-3234-1991-040d-3c0dfb3b3acb@wanadoo.fr> Date: Thu, 1 Jul 2021 19:42:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Le 01/07/2021 à 18:20, Jeroen de Borst a écrit : > On Wed, Jun 30, 2021 at 10:58 PM Christophe JAILLET > wrote: >> >> This serie is part of the effort to axe the wrappers in >> include/linux/pci-dma-compat.h >> >> While looking at it, I spotted: >> - a resource leak in an error handling path (patch 1) >> - an error code that could be propagated. (patch 2) >> This patch could be ignored. It's only goal is to be more consistent >> with other drivers. >> >> These 2 paches are not related to the 'pci-dma-compat.h' stuff, which can >> be found in patch 3. >> >> Christophe JAILLET (3): >> gve: Fix an error handling path in 'gve_probe()' >> gve: Propagate error codes to caller >> gve: Simplify code and axe the use of a deprecated API >> >> > > Thanks for these patches. > > Can split this into 2 patch series; Sure. > one for net (with the first 2 > patches) and one for net-next (with the cleanup one)? I've never worked with net and net-next directly. If just adding net and net-next after [PATCH] in the subject of the mail, yes, I can do it if it helps. BTW, I gave a look at https://patchwork.kernel.org/project/netdevbpf/list/ The patch 1/3 is marked as failed because "1 blamed authors not CCed: lrizzo@google.com; 1 maintainers not CCed: lrizzo@google.com" This author/blame was not spotted by get_maintainer.pl. Is it something I should worry about? > Also the label in the first patch should probably read > 'abort_with_gve_init' instead of 'abort_with_vge_init'. Good catch. Sorry about that. > > Jeroen > CJ