kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Zhang Qiang <qiang.zhang@windriver.com>, linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Subject: Re: [PATCH] usb: gadget: function: printer: The device interface is reset and should return error co
Date: Sun, 28 Jun 2020 13:43:10 +0000	[thread overview]
Message-ID: <37bf94a0-92a0-ca4e-a4e4-5dd44aef2b88@web.de> (raw)
In-Reply-To: <5207d179-0a7d-b5ff-af34-102fb21028b5@web.de>

I suggest to choose a more succinct patch subject.


> After the device is disconnected from the host side, the interface of
> the device is reset. If the userspace operates the device again,
> an error code should be returned.

Please use an imperative wording for the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=719fdd32921fb7e3208db8832d32ae1c2d68900f#n151


> Signed-off-by: Zqiang <qiang.zhang@windriver.com>

Did you really specify your real name here?

Regards,
Markus

  parent reply	other threads:[~2020-06-28 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  8:57 [PATCH] usb: gadget: function: printer: Fix use-after-free in __lock_acquire() Markus Elfring
2020-06-05  9:14 ` Greg Kroah-Hartman
2020-06-08  6:54 ` 回复: [PATCH] usb: gadget: function: printer: =?gb2312?B?IEZpeCB1c2UtYWZ Zhang, Qiang
2020-06-08 10:55   ` usb: gadget: function: printer: Fix use-after-free in __lock_acquire() Markus Elfring
2020-06-08 11:01     ` Greg Kroah-Hartman
2020-06-28 13:43 ` Markus Elfring [this message]
2020-06-28 14:13   ` [PATCH] usb: gadget: function: printer: The device interface is reset and should return error co Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37bf94a0-92a0-ca4e-a4e4-5dd44aef2b88@web.de \
    --to=markus.elfring@web.de \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=qiang.zhang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).