kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	mporter@kernel.crashing.org, alexandre.bounine@idt.com,
	lstoakes@gmail.com, akpm@linux-foundation.org,
	jesper.nilsson@axis.com, christian.koenig@amd.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()'
Date: Mon, 18 Sep 2017 16:04:34 +0000	[thread overview]
Message-ID: <37c07c2e-e6ed-96fa-8cdd-68bfe598eda3@deltatee.com> (raw)
In-Reply-To: <cover.1505687047.git.christophe.jaillet@wanadoo.fr>

Hey,

I don't have any relation to the rapidio code short of making a small 
change to an API it used. But I reviewed both patches and they look 
correct to me.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Logan

On 17/09/17 04:33 PM, Christophe JAILLET wrote:
> These 2 patches are really close and are both related to error handling
> in 'rio_dma_transfer()'.
> The first one fixes some resources leak in case of error.
> The 2nd one fixes a test so that the corresponding error can be handled
> correctly.
> 
> I've splitted this into 2 paches because the first one looks trivial to me.
> But the 2nd one should require more attention, IMO. The existing error
> handling was dead code because 'dma_map_sg()' can not return -EFAULT. So
> this error handling code has never been executed/tested and I can't test it
> myself.
> 
> Christophe JAILLET (2):
>    rapidio: Fix resources leak in error handling path in
>      'rio_dma_transfer()'
>    rapidio: Fix an error handling in 'rio_dma_transfer()'
> 
>   drivers/rapidio/devices/rio_mport_cdev.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 

      parent reply	other threads:[~2017-09-18 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 22:33 [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Christophe JAILLET
2017-09-17 22:33 ` [PATCH 1/2] rapidio: Fix resources leak in error handling path in 'rio_dma_transfer()' Christophe JAILLET
2017-09-17 22:33 ` [PATCH 2/2] rapidio: Fix an error handling " Christophe JAILLET
2017-09-18 16:04 ` Logan Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37c07c2e-e6ed-96fa-8cdd-68bfe598eda3@deltatee.com \
    --to=logang@deltatee.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.bounine@idt.com \
    --cc=christian.koenig@amd.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jesper.nilsson@axis.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lstoakes@gmail.com \
    --cc=mporter@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).