From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 04 Apr 2017 11:16:01 +0000 Subject: [PATCH 3/3] selinux: Use an other error code for an input validation failure in sidtab_insert() Message-Id: <38273216-97ad-7955-941a-68485534d39f@users.sourceforge.net> List-Id: References: <5704e656-708a-b611-5611-70fc65dc67e8@users.sourceforge.net> In-Reply-To: <5704e656-708a-b611-5611-70fc65dc67e8@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org From: Markus Elfring Date: Tue, 4 Apr 2017 12:23:41 +0200 The error code "-ENOMEM" was also returned so far when the parameter "s" of this function contained a null pointer. Now I find that the code "-EINVAL" is more appropriate in this case. Signed-off-by: Markus Elfring --- security/selinux/ss/sidtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c index c5f436b15d19..2eb2a54b88d2 100644 --- a/security/selinux/ss/sidtab.c +++ b/security/selinux/ss/sidtab.c @@ -36,7 +36,7 @@ int sidtab_insert(struct sidtab *s, u32 sid, struct context *context) struct sidtab_node *prev, *cur, *newnode; if (!s) - return -ENOMEM; + return -EINVAL; hvalue = SIDTAB_HASH(sid); prev = NULL; -- 2.12.2