From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Fri, 10 Jul 2020 08:11:00 +0000 Subject: Re: scsi: virtio_scsi: Remove unnecessary condition checks Message-Id: <39c76c43-cd5f-40cb-7225-e2e143f8c131@web.de> List-Id: References: <8eb9a827-45f1-e71c-0cbf-1c29acd8e310@web.de> <58e3feb8-1ffb-f77f-cf3a-75222b3cd524@redhat.com> <9815ef2d-d0da-d197-49d7-83559d750ff1@web.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Paolo Bonzini , Xianting Tian , linux-scsi@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "James E. J. Bottomley" , Jason Wang , "Martin K. Petersen" , "Michael S. Tsirkin" , Stefan Hajnoczi >> Can a bit more “compliance” (with the Linux coding style) matter here? > > No. Please take another look at the corresponding software documentation. >>> Having a single error loop is an advantage by itself. >> >> I do not see that a loop is involved in the implementation of the function “init”. > > s/loop/label/ sorry. Thanks for this information. Can the development attention grow for corresponding implementation details around the specifcation of efficient exception handling? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=42f82040ee66db13525dc6f14b8559890b2f4c1c#n465 Regards, Markus